On Thu, Sep 19, 2019 at 02:45:53PM +0200, Andrea Bolognani wrote:
On Thu, 2019-09-19 at 09:36 +0100, Daniel P. Berrangé wrote:
On Thu, Sep 19, 2019 at 10:20:04AM +0200, Pavel Hrdina wrote:
Another argument from my side was that we require syntax-check and check to be executed before posting patches to mailing list, having it under single target would simplify things for new contributors and would align more with meson community and projects.
This is pretty nice. I've been guilty of posting patches that passed check but not syntax-check in the past O:-) and I know for a fact I'm not the only one who's done that ;)
Dan pointed out an issue with our CI that we would loose the separation in our CI results, which can be solved by using 'suite' labels for tests that we run, so for syntax-check we can use 'syntax' label and for unit tests we can use 'unit' label, there can be multiple labels assigned to each test and to run only a set of tests with a specific label we just need to run these commands:
meson test --suite syntax meson test --suite unit
This way we would still have the separation in our CI and contributors could easily run `meson test` or `ninja test` to run everything.
Yes, that's a usable approach.
Jumping in a bit late, but why do we care about this distinction in CI at all? In our existing setup, for all projects 'make check' is executed if and only if 'make syntax-check' has succeeded, so the separation is fairly arbitrary and doesn't really buy us anything as far as I can tell.
I thought we ran the two jobs in parallel but I guess not. Mostly I'm interested in having CI failure mails contain clear error information. With the jobs we currently have I find the alerts from the syntax-check jobs clearer/easier to consume, than the check jobs. So I'm wary in having the syntax-check results just be intermingled with the check job results. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|