Re: [libvirt] [PATCHv2 1/3] virsh: modify vshStringToArray to duplicate the elements too

On 08/20/2013 09:45 AM, Peter Krempa wrote: >>> +++ b/tools/virsh.h >>> @@ -37,6 +37,7 @@ >>> # include "virerror.h" >>> # include "virthread.h" >>> # include "virnetdevbandwidth.h" >>> +# include "virstring.h" >> >> Is this change necessary? >> > > It's to import virStringFreeList to virsh as it's used to free the > string list from vshStringToArray in most places. Adding it to the > corresponding files calling it might save half of the includes though. I > can change it to separate includes if you wish so. I can live with it either way; it doesn't hurt too much to make virsh.h a convenience header that pulls in lots of extras to make life for the individual virsh-*.c files easier.