On 1/8/20 7:49 AM, Nikolay Shirokovskiy wrote:
Currently iotune group impl has several bugs/oddities this patchset
aims to fix. Also patches (2) and (3) add/change functionality so
that group iotune became easier/saner to use.
TODO: add docs to API/virsh in respect to using iotune group
Nikolay Shirokovskiy (7):
conf: refactor virDomainBlockIoTuneInfoHas*
conf: expand iotune params if only group name is given (2)
qemu: check iotune params same for all disk in group
qemu: fix using defaults when setting persistent iotune params
qemu: propagate iotune settings to all disks in the group
qemu: get defaults from iotune group we move disk into (3)
qemu: when leaving iotune group update xml properly
src/conf/domain_conf.c | 104 +++++++++++++++++++++++++++++++++++++++
src/conf/domain_conf.h | 16 ++++++
src/libvirt_private.syms | 5 ++
src/qemu/qemu_command.c | 90 ++++++++++++++-------------------
src/qemu/qemu_command.h | 3 ++
src/qemu/qemu_driver.c | 98 ++++++++++++++++++++++++++++++++++--
src/qemu/qemu_hotplug.c | 2 +-
tests/qemublocktest.c | 2 +-
8 files changed, 262 insertions(+), 58 deletions(-)
I will repost your patches with the fixes I think should be merged into
individual patches, if that is okay with you.
Michal