Re: [libvirt] [PATCH] openvz: swap <source bridge=...> with <target dev=...>

2008/9/29 Evgeniy Sokolov <evg(a)openvz.org&gt; > > On Mon, Sep 29, 2008 at 04:11:39PM +0400, Evgeniy Sokolov wrote: >> >>> 2008/9/29 Evgeniy V. Sokolov <evg(a)parallels.com <mailto: >>> Patch looks good. >>> But currently it will work strange because of all drivers (except OpenVZ) >>> in libvirt require specified <source bridge=""/> - it is generic. >>> With patch you need to specify both >>> <source bridge='eth10'/> - to satisfy common requirements >>> <target dev='eth10'/> - to create network >>> >> >> That is not right. The <target> element *must* be optional when creating >> a new domain. If omitted, the driver must generated a suitable target >> dev according to its desired naming scheme. Only the <source> element >> can be compulsory >> > > Agree with you. You say about "how should it be". I say about "how is it > now". > Currenty OpenVZ driver don't generate device name - my mistake. Is vnet$i (where $i is the number of automatically generated interface name for this container) appropriate?