Re: [libvirt] [python PATCH] build: make it easier to backport event ids

On Thu, Jan 15, 2015 at 08:52:44AM -0700, Eric Blake wrote: > On 01/15/2015 03:51 AM, Jiri Denemark wrote: >> On Thu, Jan 15, 2015 at 10:42:39 +0000, Daniel Berrange wrote: >>> On Wed, Jan 14, 2015 at 08:08:16PM -0700, Eric Blake wrote: >>>> In some cases, it is very easy for downstream distros to backport >>>> enum values without requiring a .so bump. Keying the conditional >>>> code off of the upstream version where the enum value was added >>>> is not ideal, because downstream then has to patch that the feature >>>> is available in their build that still reports an earlier version >>>> number. For example, if RHEL 7 backports events from 1.2.11 into >>>> a build based on 1.2.8, building the python bindings would warn:

Sigh. In a sane world we would just fix the CPP to honour enums directly ;-P

> So does this count as an ACK with the long line fixed? Sure, ACK