On Wed, Dec 18, 2019 at 10:43:11AM -0500, Cole Robinson wrote:
The phyp driver was added in 2009 and does not appear to have had any real feature change since 2011. There's virtually no evidence online of users actually using it. IMO it's time to kill it.
Signed-off-by: Cole Robinson <crobinso@redhat.com> --- I raised this in 3.5 years ago: https://www.redhat.com/archives/libvir-list/2016-April/msg01060.html
Not much on phyp/ side has changed since then, except dozens of dev patches transitioning the code forward.
That mail also mentions xenapi and hyperv. hyperv saw signs of life afterwards and is still around. xenapi has been removed, along with uml.
Considering the amount of code transitions we are currently undergoing (gnulib, glib, memory auto cleanup, etc), phyp/ will probably have an uptick of dev energy in the medium term. Let's bite the bullet and remove it!
docs/aclpolkit.html.in | 4 - docs/api.html.in | 2 +- docs/drivers.html.in | 1 - docs/drvphyp.html.in | 50 - docs/schemas/capability.rng | 3 +- docs/schemas/domaincommon.rng | 2 +- libvirt.spec.in | 11 +- m4/virt-driver-phyp.m4 | 48 - mingw-libvirt.spec.in | 7 - po/POTFILES.in | 1 - src/Makefile.am | 1 - src/README | 1 - src/libvirt.c | 10 - src/phyp/Makefile.inc.am | 21 - src/phyp/phyp_driver.c | 3739 --------------------------------- src/phyp/phyp_driver.h | 24 - 16 files changed, 4 insertions(+), 3921 deletions(-) delete mode 100644 docs/drvphyp.html.in delete mode 100644 m4/virt-driver-phyp.m4 delete mode 100644 src/phyp/Makefile.inc.am delete mode 100644 src/phyp/phyp_driver.c delete mode 100644 src/phyp/phyp_driver.h
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com> Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|