Re: [libvirt PATCH] virvhba.c: use g_autofree

On 10/16/22 12:47, ttxine wrote:

Change strings to use g_autofree.

Signed-off-by: Maxim Kostin <ttxinee@outlook.com> --- src/util/virvhba.c | 21 +++++++-------------- 1 file changed, 7 insertions(+), 14 deletions(-)

We can do a bit more. Some variables are only used within loop bodies. Those can be declared inside of their respective bodies and marked as g_autofree. After this, some labels contain nothing just a return statement, so those can be dropped too. I'm fixing those places and pushing. Congratulations on your first libvirt contribution! Reviewed-by: Michal Privoznik <mprivozn@redhat.com> Michal