On 08/09/2012 09:20 AM, Daniel P. Berrange wrote:
From: "Daniel P. Berrange" <berrange@redhat.com>
Currently the virNetServerServicePtr is responsible for creating the virNetServerClientPtr instance when accepting a new connection. Change this so that the virNetServerServicePtr merely gives virNetServerPtr a virNetSocketPtr instance. The virNetServerPtr can then create the virNetServerClientPtr as it desires
Yes, that seems like a better division of labor.
Signed-off-by: Daniel P. Berrange <berrange@redhat.com> --- src/libvirt_private.syms | 4 ++-- src/rpc/virnetserver.c | 14 ++++++++++++-- src/rpc/virnetserverclient.c | 4 +--- src/rpc/virnetserverservice.c | 38 +++++++++++++++----------------------- src/rpc/virnetserverservice.h | 4 +++- 5 files changed, 33 insertions(+), 31 deletions(-)
ACK. -- Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org