2011/1/29 Eric Blake <eblake@redhat.com>:
On 01/28/2011 03:39 PM, Matthias Bolte wrote:
+ if (!editor) + editor = "vi"; /* could be cruel & default to ed(1) here */
When VISUAL and EDITOR isn't set we fallback to vi here, but ...
+ cmd = virCommandNewArgList("sh", "-c", NULL); + virCommandAddArgFormat(cmd, "%s %s", editor, filename); + } else { + cmd = virCommandNewArgList("editor", filename, NULL);
AARGH - stupid typo. That should be 'editor', not '"editor"'. (Can you tell that I tested the patch with EDITOR='emacs -nw' in my environment, and not with EDITOR unset or a simple shell word?)
Anyway, that's minor and doesn't affect my ACK.
It does affect me applying the patch, though.
Well, I misunderstood the logic here and thought that you want to fallback to the editor command here, as editor exists on my system as /usr/bin/editor -> /etc/alternatives/editor. Now I understand the problem here and revoke my previous ACK :) Matthias