On Thu, May 03, 2018 at 03:21:01PM +0200, Katerina Koukiou wrote:
On Thu, 2018-05-03 at 14:46 +0200, Pavel Hrdina wrote:
> For some of these properties there is no libvirt event to detect the
> change and for properties where we could somehow detect the change
> let's annotate them as well.
>
> We could change the properties to methods but with the annotation we
> can keep them as properties in order to allow to get them by single
> D-Bus call.
>
> Signed-off-by: Pavel Hrdina <phrdina(a)redhat.com>
> ---
> data/org.libvirt.Connect.xml | 3 +++
> data/org.libvirt.Domain.xml | 9 +++++++++
> data/org.libvirt.Network.xml | 3 +++
> 3 files changed, 15 insertions(+)
>
Maybe it would be nicer to set `false` as the default annotation for
EmitsChangedSignal in the enclosing interface element and explicitly
mark the rest. But I am ok with this as well.
Good point, I missed that in D-Bus specification that the annotation can
be for the whole interface. I'll sent v2.
Thanks,
Pavel