Re: [libvirt] [libvirt-php][PATCH 3/7] installation_get_xml: Don't override defaults of <on_reboot/> and friends
On Thu, Dec 07, 2017 at 10:22:58AM +0100, Michal Privoznik wrote:
We don't really need to override the defaults because libvirt
chooses sane ones.
Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com>
---
src/libvirt-php.c | 6 ------
1 file changed, 6 deletions(-)
diff --git a/src/libvirt-php.c b/src/libvirt-php.c
index 51534a5..307412e 100644
--- a/src/libvirt-php.c
+++ b/src/libvirt-php.c
@@ -2345,9 +2345,6 @@ char *installation_get_xml(virConnectPtr conn, char *name, int
memMB,
" %s\n"
" </features>\n"
" <clock offset=\"%s\"/>\n"
- " <on_poweroff>destroy</on_poweroff>\n"
- " <on_reboot>destroy</on_reboot>\n"
You should preserve the <on_reboot> element here, since the default action
in libvirt for that is restart, but we're installing a new guest so you want to
destroy it in order to alter the post-install configuration.
- "
<on_crash>destroy</on_crash>\n"
" <vcpu>%d</vcpu>\n"
" <devices>\n"
" <emulator>%s</emulator>\n"
@@ -2388,9 +2385,6 @@ char *installation_get_xml(virConnectPtr conn, char *name, int
memMB,
" %s\n"
" </features>\n"
" <clock offset=\"%s\"/>\n"
- " <on_poweroff>destroy</on_poweroff>\n"
- " <on_reboot>destroy</on_reboot>\n"
- " <on_crash>destroy</on_crash>\n"
This chunk is fine though, since the configuration has been modified and it's
the final modification before the first post-install bootup.
Reviewed-by: Erik Skultety <eskultet(a)redhat.com>