On 08/20/2012 10:58 PM, Laine Stump wrote:
On 08/20/2012 07:48 PM, Eric Blake wrote:
Last of the file splits.
* tools/virsh-volume.h: New file. * tools/Makefile.am (virsh_SOURCES): Build it. * tools/virsh.c: Use new header. * tools/virsh-volume.c: Likewise. --- tools/Makefile.am | 3 +-- tools/virsh-volume.c | 36 +++++++++++++++++++++++++----------- tools/virsh-volume.h | 43 +++++++++++++++++++++++++++++++++++++++++++ tools/virsh.c | 3 +-- 4 files changed, 70 insertions(+), 15 deletions(-) create mode 100644 tools/virsh-volume.h
Another one that does the standard stuff plus rename flag to flags, and use virCheckFlags to validate the VSH_BYx values used.
ACK.
I fixed the commit message nit you pointed out, double-checked that the patches all build independently and pass syntax-check (I had to tweak one or two #define lines to pass cppi), and pushed the series. Osier will have to rebase his pending virsh changes for the 40+ listAll series, but I think the end result will be much easier to follow. -- Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org