On Fri, Jun 24, 2016 at 01:12:40PM -0400, Cole Robinson wrote:
On 06/24/2016 12:38 PM, Daniel P. Berrange wrote:
The VIR_STORAGE_POOL_EVENT_REFRESHED constant does not reflect any change in the lifecycle of the storage pool.
It should thus not be part of the storage pool lifecycle event set, but rather be a top level event in its own right. Thus we introduce VIR_STORAGE_POOL_EVENT_ID_REFRESH to replace it.
Signed-off-by: Daniel P. Berrange <berrange@redhat.com> ---
NB this breaks API and wire protocol, so we *must* include this before 2.0.0. Ideally we should get it into before we cut any rc release too.
ACK, I didn't see anything wrong here.
I don't think any libvirt-python changes are needed either since this is using the same generic callback, except tweaking event-test.py which isn't time critical. Sorry for the last minute rush...
It looks like we do need some python changes in the C glue layer Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|