Re: [libvirt] [PATCH v1 19/21] tools: remove unneeded cleanup labels

12 Nov 2019


      On Mon, Oct 21, 2019 at 03:19:09PM -0300, Daniel Henrique Barboza wrote:
...
Signed-off-by: Daniel Henrique Barboza <danielhb413@gmail.com>
---
tools/virsh-completer-network.c |  8 ++-----
tools/virsh-domain.c            | 41 +++++++++++----------------------
tools/vsh.c                     | 14 +++++------
3 files changed, 22 insertions(+), 41 deletions(-)
@@ -5056,7 +5048,7 @@ cmdSchedInfoUpdateOne(vshControl *ctl,
                                        field, param->type,
                                        value) < 0) {
            vshSaveLibvirtError();
-            goto cleanup;
+            return ret;
return -1;
...
}
        ret = 0;
        break;
Reviewed-by: Ján Tomko <jtomko@redhat.com>

Jano

    