Re: [libvirt] [PATCH v10 2/4] domain: Add optional 'tls' attribute for TCP chardev
On 10/21/2016 07:57 AM, Pavel Hrdina wrote:
On Fri, Oct 21, 2016 at 07:15:55AM -0400, John Ferlan wrote:
>
>
> On 10/21/2016 02:29 AM, Pavel Hrdina wrote:
>> On Thu, Oct 20, 2016 at 03:48:30PM -0400, John Ferlan wrote:
>>> [...]
>>>
>
> Since I assume you have these changes in your local branch - let's go
> with the two patches and move on.
>
> It would be nice while it's still fresh to update the documentation, but
> that's a separate patch.
>
> So "officially" it's an ACK of your changes on top of and in addition
to
> my changes.
>
> John
We should probably figure out also rng, smartcard and redirdevs before pushing.
They also use the source as you've pointed out and currently they can be
configured to use TLS with the chardev_tls config option. I'll send a new
version of patch series to cover all users of TCP source type.
The rng, smartcard, and redirdevs for hotplug is a different issue
though. They come more into play when adding the passphrase.
As painful as it is (or will be to review) - I'm trying to move the
privateData from virDomainChrDef to virDomainChrSourceDef. That will
then magically do the right thing for rng, smartcard, and redirdevs.
Right now for command line processing they work fine since adding the
tls-creds is based on virDomainChrSourceDef
John