Re: [libvirt] [Qemu-devel] [PATCH for-4.0 v2] virtio: Provide version-specific variants of virtio PCI devices
Hi,
This series seems to have some coding style problems. See output below for
more information:
Message-id: 20181114233831.10374-1-ehabkost(a)redhat.com
Type: series
Subject: [Qemu-devel] [PATCH for-4.0 v2] virtio: Provide version-specific variants of
virtio PCI devices
=== TEST SCRIPT BEGIN ===
#!/bin/bash
BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
failed=1
echo
fi
n=$((n+1))
done
exit $failed
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
20332af virtio: Provide version-specific variants of virtio PCI devices
=== OUTPUT BEGIN ===
Checking PATCH 1/1: virtio: Provide version-specific variants of virtio PCI devices...
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#668:
new file mode 100644
ERROR: line over 90 characters
#724: FILE: tests/acceptance/virtio_version.py:52:
+ return devtype in [d['name'] for d in vm.command('qom-list-types',
implements=implements)]
ERROR: line over 90 characters
#726: FILE: tests/acceptance/virtio_version.py:54:
+def get_interfaces(vm, devtype, interfaces=['pci-express-device',
'conventional-pci-device']):
WARNING: line over 80 characters
#780: FILE: tests/acceptance/virtio_version.py:108:
+ dev_1_0,nt_ifaces = self.run_device('%s-non-transitional' %
(qemu_devtype))
WARNING: line over 80 characters
#804: FILE: tests/acceptance/virtio_version.py:132:
+ dev_trans,trans_ifaces = self.run_device('%s-transitional' %
(qemu_devtype))
total: 2 errors, 3 warnings, 732 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===
Test command exited with code: 1
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel(a)redhat.com