Re: [libvirt] [Qemu-devel] [PATCH 2/2] qapi: deprecate implicit filters
On Thu, Aug 15, 2019 at 12:49:28 +0200, Kevin Wolf wrote:
Am 14.08.2019 um 21:27 hat John Snow geschrieben:
[...]
> example:
>
> { "return": {},
> "deprecated": True,
> "warning": "Omitting filter-node-name parameter is deprecated, it
will
> be required in the future"
> }
>
> There's no "error" key, so this should be recognized as success by
> compatible clients, but they'll definitely see the extra information.
>
> Part of my motivation is to facilitate a more aggressive deprecation of
> legacy features by ensuring that we are able to rigorously notify users
> through any means that they need to adjust their scripts.
Who would read this, though? In the best case it ends up deep in a
libvirt log that nobody will look at because there was no error. In the
more common case, the debug level is configured so that QMP traffic
isn't even logged.
The best we could do here is to log a warning. Thankfully we have one
central function which always checks the returned JSON from qemu so we
could do that universally.
The would end up in the system log and alternatively also in the VM
log file. I agree with Kevin that the possibility of it being noticed
is rather small.
From my experience users report non-fatal messages mostly only if it is
spamming the system log. One of instances are very unlikely to be
noticed.
In my experience it's better to notify us in libvirt of such change and
we will try our best to fix it.
Attachments:
- signature.asc (application/pgp-signature — 833 bytes)