Re: [libvirt PATCH 3/6] virt-ssh-helper: Add manual page
On Fri, Dec 10, 2021 at 06:23:22PM +0100, Ján Tomko wrote:
On a Friday in 2021, Andrea Bolognani wrote:
> docs/manpages/meson.build | 1 +
> docs/manpages/virt-ssh-helper.rst | 96 +++++++++++++++++++++++++++++++
> libvirt.spec.in | 1 +
> 3 files changed, 98 insertions(+)
> create mode 100644 docs/manpages/virt-ssh-helper.rst
Sorry, I mistakenly thought you had R-b'd the entire series so I have
already pushed it! :(
I'm not convinced we need a manual page for an internal tool.
We don't have one for any other -helper binaries and qemu-bridge-helper
also comes without a man page.
The difference between the other helpers and virt-ssh-helper is that
the latter is installed in the default $PATH.
So a random user is likely to see the name when using shell
completion after typing "virt-" and wonder what the tool is all
about. I think that justifies having a brief manual page for it.
--
Andrea Bolognani / Red Hat / Virtualization