Re: [libvirt] [PATCH] add compress stream support
On Tue, Sep 22, 2015 at 10:26:19PM +0000, Vasiliy Tolstov wrote:
Some libvirt functions use streams, this patch add
compress stream support.
So VolumeDownload/VolumeUpload can greatly speedup by using
compressed streams to save network bandtwidth and don't transfer
zero bytes (in case of raw disk format)
How have you actually tested this in practice - your patch does
not change any code to make use of this new feate. You're changing
the public API which suggests you expect the client apps to use
this when passing a virStreamPtr to the virStorageVolDownload
method, but the stream client apps pass is not backed by a
virFDStream object. Only libvirtd uses the virFDSteam objects
and you've not changed anything to make use ot that. So this is
all rather strange still. Can you more clearly state what you
are expecting to do.
Regards,
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|