Re: [libvirt] [PATCH 06/13] qemu_command: Resolve resource leaks found by Valgrind
On Wed, Feb 06, 2013 at 04:35:40PM -0500, John Ferlan wrote:
The qemuParseGlusterString() replaced dst->src without a
VIR_FREE() of
what was in there before.
The qemuBuildCommandLine() did not properly free the boot_buf depending
on various usages.
The qemuParseCommandLineDisk() had numerous paths that didn't clean up
the virDomainDiskDefPtr def properly. Adjust the logic to go through an
error: label before cleanup in order to free the resource.
---
src/qemu/qemu_command.c | 68 ++++++++++++++++++++++---------------------------
ACK
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|