Re: [libvirt] [PATCH 5/7] Add virCommandSetMockOutputFile
On 03/12/2014 03:26 PM, Daniel P. Berrange wrote:
On Wed, Mar 12, 2014 at 02:08:15PM +0100, Ján Tomko wrote:
> > After this file is set, all commands executed will be replaced by
> > cat <file>.
I think this is a bit too special case and unecessarily forces
use of an external cat command. I think your test would be
easier if using this callback approach I've just proposed
https://www.redhat.com/archives/libvir-list/2014-March/msg00733.html
Definitely nicer, but it doesn't work with asynchronous commands.
Jan
Attachments:
- signature.asc (application/pgp-signature — 836 bytes)