On Mon, Oct 02, 2006 at 07:31:41PM +0100, Daniel P. Berrange wrote:
Updating for this ABI breakage is beginning to feel like a never
ending
problem :-( It seems I missed one change in my last patch - mlock()'ing
the wrong bit of data for getdomainlist. By (bad) luck it just happened
to work anyway on my tests because I guess there was sufficient allocated
memory that mlock() was still in range. Running unprivileged via the proxy
though, the proxy will always request info on 1020 domains (even if only
a couple are running), which meant we mlock() several 10's of KB of data.
THis ran in an area on unallocated mem & caused mlock() to fail, hence
my discovering the problem.
urgh !
Anyway, attached is the patch I've applied to CVS...
Thanks for spotting this! I fixed the munlock -> mlock transition :-)
and updated the error messages to report the new sizes,
Daniel
--
Red Hat Virtualization group
http://redhat.com/virtualization/
Daniel Veillard | virtualization library
http://libvirt.org/
veillard(a)redhat.com | libxml GNOME XML XSLT toolkit
http://xmlsoft.org/
http://veillard.com/ | Rpmfind RPM search engine
http://rpmfind.net/