Re: [libvirt] [PATCH] qemu: Fix specifying char devs for PPC
On 2014年05月21日 14:00, Ján Tomko wrote:
On 05/20/2014 07:25 AM, Hong-Hua.Yin(a)freescale.com wrote:
> Hi Cole,
>
> Thanks for the comments.
> Exactly there were already test cases for both pseries and ppce500 machines.
> For example,
> 1) qemuxml2argv-pseries-basic.args: '-chardev spapr-vty' for pseries.
> 2) qemuxml2argv-ppc-dtb.args: '-serial pty' for ppce500.
The dtb test is run as:
DO_TEST("ppc-dtb", QEMU_CAPS_KVM, QEMU_CAPS_DTB);
You need a test which is run with both QEMU_CAPS_DEVICE and QEMU_CAPS_CHARDEV
capabilities to test the changes in virQEMUCapsSupportsChardev, otherwise
it just returns false at the beginning.
Hi Hong-Hua,
Jan is right.
That case doesn't test the code which is changed.
Because QEMU_CAPS_DEVICE and QEMU_CAPS_CHARDEV is not set,
it won't run into your code.
You can add these two capabilities to this case to verify your code. :)
Thanks.
Li
Jan
--
libvir-list mailing list
libvir-list(a)redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list