Re: [libvirt] [PATCH 4/4] qemu: Add support for setting the TSEG size

On Thu, Jun 07, 2018 at 10:37:43AM +0200, Martin Kletzander wrote: >The default is stable per machine type so there should be no need to keep that. > >Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1469338 > >Signed-off-by: Martin Kletzander <mkletzan(a)redhat.com&gt; >--- > src/conf/domain_conf.c | 3 +- > src/qemu/qemu_command.c | 18 ++++++++ > src/qemu/qemu_domain.c | 35 ++++++++++++++ > .../tseg-explicit-size.x86_64-latest.args | 35 ++++++++++++++ > tests/qemuxml2argvdata/tseg-explicit-size.xml | 23 ++++++++++ > tests/qemuxml2argvdata/tseg-i440fx.xml | 23 ++++++++++ > tests/qemuxml2argvdata/tseg-invalid-size.xml | 23 ++++++++++ > tests/qemuxml2argvtest.c | 25 ++++++++++ > .../qemuxml2xmloutdata/tseg-explicit-size.xml | 46 +++++++++++++++++++ > .../tseg-old-machine-type.xml | 44 ++++++++++++++++++ > tests/qemuxml2xmloutdata/tseg.xml | 44 ++++++++++++++++++ > tests/qemuxml2xmltest.c | 9 ++++ > 12 files changed, 327 insertions(+), 1 deletion(-) > create mode 100644 tests/qemuxml2argvdata/tseg-explicit-size.x86_64-latest.args > create mode 100644 tests/qemuxml2argvdata/tseg-explicit-size.xml > create mode 100644 tests/qemuxml2argvdata/tseg-i440fx.xml > create mode 100644 tests/qemuxml2argvdata/tseg-invalid-size.xml > create mode 100644 tests/qemuxml2xmloutdata/tseg-explicit-size.xml > create mode 100644 tests/qemuxml2xmloutdata/tseg-old-machine-type.xml > create mode 100644 tests/qemuxml2xmloutdata/tseg.xml > >diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c >index 62bf6bb803bb..e83487d6b0de 100644 >--- a/src/conf/domain_conf.c >+++ b/src/conf/domain_conf.c >@@ -22043,7 +22043,8 @@ virDomainDefFeaturesCheckABIStability(virDomainDefPtr src, > return false; > } > >- if (src->tseg_size != dst->tseg_size) { >+ if (src->tseg_specified && Why this change? IIUC if they weren't specified on both sides, they should both be 0 here. If you're sure it's needed, put it in the commit adding this check.