Re: [libvirt] [PATCH] Added QEMU support for IVSHMEM devices

On 09/24/2012 09:44 AM, Shawn Furrow wrote: [sorry for my delay in replying] > *Created at Virginia Tech's Systems Software Research Group > > This patch adds the XML schema and implementation for IVSHMEM device driver > support. Currently it defaults to using interrupts. A sample IVSHMEM entry > in the VM's XML file is: Thanks for starting to tackle this. > > <ivshmem id='nahanni' size='16834' path='/tmp/'/> Elsewhere, we have represented memory sized in KiB (1024 byte units); what scale are you using here? A default unit of byte might be nicer, on the other hand, does shared memory have to be page aligned, at which point it will always be a multiple of 4k (and thus listing in KiB still makes sense)? At any rate, I think that this argues you need to support units on output to show the preferred scale, as well as parse it on input to allow users to specify units='M' size='1' to reserve 2**20 bytes with ease.