Re: [libvirt] [RFC Patch 0/3]virsh: Enable env support for virsh logging
On Thu, May 19, 2011 at 12:19:11PM -0600, Eric Blake wrote:
On 05/09/2011 01:07 AM, Supriya Kannery wrote:
> Defining environment variables for debug log-level and log-file will avoid
> specifying the same in each virsh command. Following is a patchset
> for enabling env variable support for virsh logging.
>
> Two new environment variables are defined:
>
> a. VIRSH_DEBUG=<log_level>
> log_level can be a value between 0 - 4, where
> 0 -> "ERROR"
> 1 -> "WARNING"
> 2 -> "NOTICE"
> 3 -> "INFO"
> 4 -> "DEBUG"
This is exactly the opposite to LIBVIRT_DEBUG=<log level> which
has
* 1: DEBUG
* 2: INFO
* 3: WARNING
* 4: ERROR
IMHO, these need to be kept the same.
> b. VIRSH_LOG_FILE=<logfile-path-and-name>
> logfile-path-and-name is the name and complete path for the log file.
>
> The above two variables are independent.
> if log_level is specified without setting a log file name,
> then, logs will be displayed in stdio.
> If logfile-path-and-name specified without setting log_level,
> then, default log_level (DEBUG) will be used to log to the specified file.
Seems reasonable to me. I'm now in the middle of reviewing the patch set.
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|