Re: [libvirt PATCH v2 26/56] src: conditionalize use of O_DIRECT
On Tue, Jan 28, 2020 at 01:11:07PM +0000, Daniel P. Berrangé wrote:
The O_DIRECT flag is not available on all platforms, so we
must introduce a compat define the same way gnulib does.
Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com>
---
src/util/iohelper.c | 4 ++++
src/util/virfile.c | 4 ++++
2 files changed, 8 insertions(+)
I would rather have all the O_* compat defines at one place then
scattered through our code.
We have the O_CLOEXEC in src/internal.h, O_DIRECT in these two files
and following patch adds guard around O_BINARY in
src/util/virfdstream.c.
I'll leave it up to you if decide to group all of them or leave it as
it is.
Reviewed-by: Pavel Hrdina <phrdina(a)redhat.com>
Attachments:
- signature.asc (application/pgp-signature — 833 bytes)