Re: [libvirt] [for-1.2.3 PATCHv3] gluster: Fix "key" attribute for gluster volumes

On 03/31/2014 06:18 AM, Peter Krempa wrote: > According to our documentation the "key" value has the following > meaning: "Providing an identifier for the volume which identifies a > single volume." The currently used keys for gluster volumes consist of > the gluster volume name and file path. This can't be considered unique > as a different storage server can serve a volume with the same name. > > Unfortunately I wasn't able to figure out a way to retrieve the gluster > volume UUID which would avoid the possibility of having two distinct > keys identifying a single volume. > > Use the full URI as the key for the volume to avoid the more critical > ambiguity problem and document the possible change to UUID. > --- > > +++ b/docs/storage.html.in > @@ -711,12 +711,14 @@ > correspond to the files that can be found when mounting the > gluster volume. The <code>name</code> is the path relative to > the effective mount specified for the pool; and > - the <code>key</code> is a path including the gluster volume > - name and any subdirectory specified by the pool.</p> > + the <code>key</code> is a string that identifies a single volume > + uniquely. Currently the <code>key</code> attribute consists of the > + URI of the volume but it may be changed to an UUID of the volume s/an UUID/a UUID/ The rule on article selection with 'u' is determined by pronunciation: 'an umbrella' vs. 'a unicorn', based on whether the leading vowel has a hard 'you' sound vs. a soft 'uh' sound. In this case, the acronym is pronounced 'you-you-eye-dee'. (Similar for 'an hour' vs. 'a house' on whether an 'h' is pronounced). ACK with that fix, and I agree about getting it in for 1.2.3