Re: [libvirt] [PATCHv5 02/19] util: Introduce resctrl monitor for CMT
-----Original Message-----
From: John Ferlan [mailto:jferlan@redhat.com]
Sent: Wednesday, October 10, 2018 7:08 AM
To: Wang, Huaqiang <huaqiang.wang(a)intel.com>; libvir-list(a)redhat.com
Cc: Feng, Shaohe <shaohe.feng(a)intel.com>; Niu, Bing <bing.niu(a)intel.com>;
Ding, Jian-feng <jian-feng.ding(a)intel.com>; Zang, Rui <rui.zang(a)intel.com>
Subject: Re: [libvirt] [PATCHv5 02/19] util: Introduce resctrl monitor for CMT
On 10/9/18 6:30 AM, Wang Huaqiang wrote:
> Cache Monitoring Technology (aka CMT) provides the capability to
> report cache utilization information of system task.
>
> This patch introduces the concept of resctrl monitor through data
> structure virResctrlMonitor.
>
> Signed-off-by: Wang Huaqiang <huaqiang.wang(a)intel.com>
> ---
> src/libvirt_private.syms | 1 +
> src/util/virresctrl.c | 56
++++++++++++++++++++++++++++++++++++++++++++++++
> src/util/virresctrl.h | 7 ++++++
> 3 files changed, 64 insertions(+)
>
> diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms index
> 335210c..d2573c5 100644
> --- a/src/libvirt_private.syms
> +++ b/src/libvirt_private.syms
> @@ -2680,6 +2680,7 @@ virResctrlInfoGetCache;
> virResctrlInfoGetMonitorPrefix; virResctrlInfoMonFree;
> virResctrlInfoNew;
> +virResctrlMonitorNew;
>
>
> # util/virrotatingfile.h
> diff --git a/src/util/virresctrl.c b/src/util/virresctrl.c index
> 697424c..18ee560 100644
> --- a/src/util/virresctrl.c
> +++ b/src/util/virresctrl.c
> @@ -105,6 +105,7 @@ typedef virResctrlAllocMemBW
> *virResctrlAllocMemBWPtr;
> /* Class definitions and initializations */ static virClassPtr
> virResctrlInfoClass; static virClassPtr virResctrlAllocClass;
> +static virClassPtr virResctrlMonitorClass;
>
>
> /* virResctrlInfo */
> @@ -319,6 +320,35 @@ struct _virResctrlAlloc {
> char *path;
> };
>
> +/* virResctrlMonitor */
> +
> +/*
> + * virResctrlMonitor is the data structure for resctrl monitor.
> +Resctrl
> + * monitor represents a resctrl monitoring group, which can be used
> +to
> + * monitor the resource utilization information for either cache or
> + * memory bandwidth.
> + *
> + * From hardware perspective, cache monitoring technology (CMT),
> +memory
> + * bandwidth technology (MBM), as well as the CAT and MBA, are all
> +orthogonal
> + * features. The monitor will be created under the scope of default
> +allocation
> + * if no CAT or MBA supported in the system.
"if no specific CAT or MBA entries are provided for the guest"
OK.
The rest seems reasonable at least for now, so
Reviewed-by: John Ferlan <jferlan(a)redhat.com>
John
[...]
Thanks for review.
Huaqiang