On 1/24/19 4:58 AM, Peter Krempa wrote:
Fix the generated documentation and clean up a few corner cases in qemu's block job handling.
Peter Krempa (5): lib: Fix docs generated for enum virDomainBlockJobType qemu: blockjob: Make sure that internal states are not reported as event qemu: blockjob: Mark job as started only when it's new qemu: Clear block copy mirror state explicitly qemu: Don't double-free disk->mirror if block commit initialization fails
include/libvirt/libvirt-domain.h | 3 ++- src/qemu/qemu_blockjob.c | 7 ++++++- src/qemu/qemu_driver.c | 34 ++++++++++++++------------------ 3 files changed, 23 insertions(+), 21 deletions(-)
NIT, w/r/t patch2 - maybe a code comment regarding internal states would help someone that trips across that code and wonders what the check is for. yes it's in the commit message, but not everyone goes back to the commit that added the check to see why it was done that way. Reviewed-by: John Ferlan <jferlan@redhat.com> (series) John