Re: [libvirt] [PATCH v2] qemu: Remove explicit values from virQEMUCapsFlags

On Wed, 2015-10-07 at 10:33 +0200, Jiri Denemark wrote: > > /* Internal flags to keep track of qemu command line capabilities > > */ > > typedef enum { > > + /* 0 */ > > > + QEMU_CAPS_KQEMU, /* Whether KQEMU is compiled in */ > > + QEMU_CAPS_VNC_COLON, /* VNC takes or address + display */ > > + QEMU_CAPS_NO_REBOOT, /* Is the -no-reboot flag available */ > > + QEMU_CAPS_DRIVE, /* Is the new -drive arg available */ > > + QEMU_CAPS_DRIVE_BOOT, /* Does -drive support boot=on */ > > + > + /* 5 */ > > > + QEMU_CAPS_NAME, /* Is the -name flag available */ > > + QEMU_CAPS_UUID, /* Is the -uuid flag available */ > > + QEMU_CAPS_DOMID, /* Xenner: -domid flag available */ > > + QEMU_CAPS_VNET_HDR, > > + QEMU_CAPS_MIGRATE_KVM_STDIO, /* avoid kvm tcp migration bug */ > > + > + /* 10 */ > > > + QEMU_CAPS_MIGRATE_QEMU_TCP, /* have qemu tcp migration */ > > + QEMU_CAPS_MIGRATE_QEMU_EXEC, /* have qemu exec migration */ > > + QEMU_CAPS_DRIVE_CACHE_V2, /* cache= flag wanting new v2 values > > */ > > + QEMU_CAPS_KVM, /* Whether KVM is enabled by default */ > > + QEMU_CAPS_DRIVE_FORMAT, /* Is -drive format= avail */ > > ... > > That is, group them by 5 and separate the groups with empty lines so > that > the list looks like the corresponding definition in > qemu_capabilities.c. Okay. Do you want me to send a v3 or can I just push it right away once I'm done?