Re: [libvirt] [PATCHv2] qemu: support live change of the bridge used by a guest network device

On Fri, Mar 30, 2012 at 10:30:01AM -0400, Laine Stump wrote: > From 3b277f2c2138b98145d6b5e18c844be5d43b8b29 Mon Sep 17 00:00:00 2001 > From: Laine Stump <laine(a)laine.org&gt; > Date: Fri, 30 Mar 2012 10:13:37 -0400 > Subject: [PATCH] qemu: add audit logs when switching bridges > > This adds in a standard audit log for detaching and attaching a > network device when the bridge being used is changed. > > The discussion about this led to the idea that the audit logs being > generated are insufficient, since they don't say anything about which > tap device is used, nor about which bridge it is attached to, but that > should be fixed by a separate patch, and this gets the current patch > properly wired into the infrastructure. > --- > src/qemu/qemu_hotplug.c | 8 +++++--- > 1 files changed, 5 insertions(+), 3 deletions(-) > > diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c > index 66837c4..7699e9d 100644 > --- a/src/qemu/qemu_hotplug.c > +++ b/src/qemu/qemu_hotplug.c > @@ -1194,7 +1194,8 @@ static virDomainNetDefPtr qemuDomainFindNet(virDomainObjPtr vm, > } > > static > -int qemuDomainChangeNetBridge(virDomainNetDefPtr olddev, > +int qemuDomainChangeNetBridge(virDomainObjPtr vm, > + virDomainNetDefPtr olddev, > virDomainNetDefPtr newdev) > { > const char *oldbridge = olddev->data.bridge.brname; > @@ -1221,9 +1222,11 @@ int qemuDomainChangeNetBridge(virDomainNetDefPtr olddev, > } > return -1; > } > + virDomainAuditNet(vm, NULL, olddev, "detach", true); This needs to be moved up, otherwise if we successfully detach, but fail to attach we'll not emit the audit message. Also we I think we should log "detach", false if detaching fails, and likewise 'attach', false' if attaching fails