On Thu, Jan 10, 2013 at 11:57:28AM +0100, Viktor Mihajlovski wrote:
On 01/10/2013 12:45 AM, Eric Blake wrote:
* libvirt.spec.in: Add some indentation to make it easier to follow various conditionals. --- libvirt.spec.in | 858 ++++++++++++++++++++++++++++---------------------------- 1 file changed, 428 insertions(+), 430 deletions(-)
Painful experience makes me agree that the unindented nested %ifs decrease the readability of the spec file and thus would be in favor of this patch. However, indentation seems to be uncustomary. On the other hand, it doesn't seem to be explicitly forbidden, looking at e.g. http://fedoraproject.org/wiki/Packaging:Guidelines Any packager here that wants to throw in 2 cents?
IIUC, RPM will expand macros *anywhere* in the spec file, even in places you don't want it to like comments ! So I don't think adding some whitespace will harm things Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|