Re: [libvirt] [PATCH v3 1/3] migration: add migration_host support for Ipv6 address without brackets

On Tue, 2014-10-07 at 11:08 +0200, Ján Tomko wrote:

On 10/07/2014 06:07 AM, Chen Fan wrote:

...

if specifying migration_host to an Ipv6 address without brackets, it was resolved to an incorrect address, such as: tcp:2001:0DB8::1428:4444, but the correct address should be: tcp:[2001:0DB8::1428]:4444 so we should add brackets when parsing it.

Signed-off-by: Chen Fan <chen.fan.fnst@cn.fujitsu.com> --- src/libvirt_private.syms | 2 +- src/qemu/qemu_migration.c | 49 +++++++++++++++++++++++------------------------ src/util/virsocketaddr.c | 19 +++++++++--------- src/util/virsocketaddr.h | 2 +- tests/sockettest.c | 2 +- 5 files changed, 36 insertions(+), 38 deletions(-)

ACK

Thanks.

Jan