Re: [PATCH 3/3] virLogCleanerShutdown: Don't call g_regex_unref on NULL regex

On Wed, Feb 15, 2023 at 11:06:11AM +0100, Peter Krempa wrote:

Shutdown of virtlogd prints:

(process:54742): GLib-CRITICAL **: 11:00:40.873: g_regex_unref: assertion 'regex != NULL' failed

Use g_clear_pointer instead which prevents it in the NULL case.

Fixes: 69eeef5dfbf Signed-off-by: Peter Krempa <pkrempa@redhat.com> --- src/logging/log_cleaner.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com> With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|