Re: [libvirt] [PATCH v4 1/3] qemu: extract PCI handling structs
On 05/13/2014 03:21 AM, Ján Tomko wrote:
On 05/11/2014 08:48 AM, Roman Bogorodskiy wrote:
> Introduce new files (domain_addr.[ch]) to provide
> an API for domain device handling that could be
> shared across the drivers.
>
> + * Author: Daniel P. Berrange <berrange(a)redhat.com>
> + */
> +
I think you should be the author, since you created the file.
Most of the structs and functions were (re)written by Laine anyway and we have
the copyrights and git history for attributions.
But I'd like to hear a second opinion on this.
Per-file authorship is an awkward concept in the age of multiple
contributors. When copying and pasting from another file, I tend to
preserve the original author if I used most of the code intact, or drop
the line entirely if I'm going to do a rewrite. The git log is much
more authoratative than an author comment in the file, so I don't care
enough to require you to change it - if you are comfortable claiming the
work, put your own name.
The rest is just code movement and renaming, ACK.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
Attachments:
- signature.asc (application/pgp-signature — 604 bytes)