Re: [libvirt] [PATCH] build: predictably generate systemtap tapsets (bz 1173641)

On Wed, Jan 20, 2016 at 10:06:21AM -0500, Cole Robinson wrote: > The generated output is dependent on perl hashtable ordering, which > gives different results for i686 and x86_64. Fix this by sorting > the hash keys before iterating over them > > https://bugzilla.redhat.com/show_bug.cgi?id=1173641 > --- > src/rpc/gensystemtap.pl | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/src/rpc/gensystemtap.pl b/src/rpc/gensystemtap.pl > index 2467300..7b80fbf 100755 > --- a/src/rpc/gensystemtap.pl > +++ b/src/rpc/gensystemtap.pl > @@ -72,7 +72,7 @@ function libvirt_rpc_auth_name(type, verbose) > { > EOF > my $first = 1; > -foreach my $type (keys %auth) { > +foreach my $type (sort(keys %auth)) { Nitpick, you don't really need the round brackets ie you can do sort keys %auth ACK