Eric Blake wrote:
On 11/20/2012 10:07 AM, Roman Bogorodskiy wrote:
Hi,
Recently I have picked up Sean's and Hiren's activities in porting Qemu driver on FreeBSD.
At this point I have the basics working. Meaning that these things work:
- Basic host commands (version, nodeinfo, etc) - Can perform basic operations on the VM (start, stop, destroy, etc) - Basic bridging (bridge creation/removing, adding/removing interfaces, setting addresses etc)
Currently I keep FreeBSD specific info here:
https://github.com/novel/fbsd-libvirt/blob/freebsd/README-freebsd
Thanks for your porting efforts. Is this something where you have split it into a series of patches worth incorporating upstream?
The code is available here: https://github.com/novel/fbsd-libvirt/tree/freebsd
Current changes could be observed here:
https://github.com/novel/fbsd-libvirt/compare/upstream_master...freebsd
I would appreciate your thoughts and feedback on that topic.
You're more likely to get feedback by posting actual patches here, rather than pointing us to a repo and expecting us to crawl through the differences. But here's hoping we can improve the code base as a result of your efforts.
That sounds reasonable. I'll start working on creation of the sequential patches. Roman Bogorodskiy