On Mon, Dec 04, 2017 at 03:14:33PM -0700, Jim Fehlig wrote:
On 12/04/2017 02:53 PM, Marek Marczykowski-Górecki wrote:
On Mon, Dec 04, 2017 at 02:46:58PM -0700, Jim Fehlig wrote:
There's another instance of this check in xenFormatNet() in src/xenconfig/xen_common.c. I suppose multiple IP addrs are not supported in xml <-> xl.cfg conversions. Do you have time to fix the config converter too?
Where should I put helper function to not duplicate it across those two drivers?
Would there be duplicate code? The two serve different purposes. xenconfig converts libvirt domXML to/from the various Xen config formats (xl, xm, sexpr). The libxl driver maps virDomainDef to libxl_domain_config.
In both cases I need a function that makes a space-separated list of IP addresses, out of virNetDevIPInfo struct. But the same question applies also to a loong waiting cpuid patch series (there: preparing libxl cpuid features string)... -- Best Regards, Marek Marczykowski-Górecki Invisible Things Lab A: Because it messes up the order in which people normally read text. Q: Why is top-posting such a bad thing?