Re: [libvirt] Domain XML format using defined storage volume + RFC

On Thu, 15 May 2008, Daniel P. Berrange wrote: Nevermind, my reading skills are almost as bad as my coding skills. I mixed up the type and device attributed. But implemented it directly in the type attribute and realised the true meaning of your comment too late. The code I produced is still *untested*. It does compile, but I still did not define any normal domain with libvirt, and if this works I hope my problems are all over. I don't know if you picked up the message about open-iscsi. The libopen-iscsi idea was accepted. So technically we can use their functions directly never having migrate from one sysfs to another, because 'they' fix it. So if the user has a recent version of open-iscsi, they will automatically have the right lookup algorithm. It might be interesting to 'natively' do the scanning too, without invoking the binary. If you want to do this, I'm happy to put all the functions we need in one binary and update their Makefile. The iscsi dependancy should then check for a recent open-iscsi version. Now is this a good idea? For Linux probably... but I hope you can still make friends with Solaris guys. I hope they can provide some native method too :) Sign-off-by: Stefan de Konink <dekonink(a)kinkrsoftware.nl&gt; Stefan ps. please update the AUTHORS with the above e-mail adress. I try to migrate all my email from 'personal' to 'work'.