Re: [libvirt] [PATCH 0/2] Disallow wiping a sparse logical volume
On 07/17/2014 02:10 PM, John Ferlan wrote:
John Ferlan (2):
storage: Convert 'building' into a bool
storage: Disallow vol_wipe for sparse logical volumes
src/conf/storage_conf.h | 2 +-
src/storage/storage_backend_logical.c | 39 ++++++++++++++++++++++++++++++++++-
src/storage/storage_driver.c | 8 +++----
src/util/virstoragefile.h | 1 +
4 files changed, 44 insertions(+), 6 deletions(-)
Thanks for the review - I adjusted the completely... funny when I typed
it and looked at it I thought it looked funny but my fingers were more
insistent that they had done the right thing :-)
Not sure lvremove/lvresize will do the trick here - read the 'lvmthin'
man page... Also online I found here was a reading or two online that
suggested one cannot reduce the size of a thin pool due to some lvm bug.
There's another doc that says in order to reduce the size use trim, but
I'm not quite sure how to access that.
In my "example" case - my extent size is 4096 and my thin/sparse size is
4096. Attemping to lvreduce results in a "New size given (xxx) not less
than existing size (1 extents)." So even though I've filled half of it
with 0's, there doesn't seem to be a way to do what we want.
Maybe someone has more "experience" dealing with these
In any case, I pushed what I have...
John