Re: [libvirt] [PATCH jenkins-ci 2/2] Enable mingw build for virt-viewer project

On Thu, 2018-04-12 at 15:28 +0100, Daniel P. Berrangé wrote: [...] This (and the corresponding mingw64 entry) will drag in the version of the library based on GTK+ 2 rather than the one based on GTK+ 3, which is not what we want. It should look like mingw32-gtk-vnc: FedoraRawhide: mingw32-gtk-vnc2 Because of the missing dependencies mentioned below, you also need mingw32-hicolor-icon-theme: FedoraRawhide: mingw32-hicolor-icon-theme mingw32-spice-glib: FedoraRawhide: mingw32-spice-glib plus of course the mingw64 equivalents. [...] Same as the previous patch, you need to include also the packages MinGW builds for libvirt and libvirt-glib already depend on. Additionally, a couple more (optional?) dependencies can be discovered thanks to the mingw-virt-viewer.spec.in file included in the repository. The full list should look like: - mingw32-adwaita-icon-theme - mingw32-glib2 - mingw32-curl - mingw32-dbus - mingw32-dlfcn - mingw32-gcc - mingw32-gettext - mingw32-glib-networking - mingw32-glib2 - mingw32-gstreamer1-plugins-bad-free - mingw32-gstreamer1-plugins-good - mingw32-gtk3 - mingw32-gtk-vnc - mingw32-gtk3 - mingw32-hicolor-icon-theme - mingw32-libgovirt - mingw32-libssh2 - mingw32-libusbx - mingw32-libxml2 - mingw32-pkg-config - mingw32-portablexdr - mingw32-readline - mingw32-rest - mingw32-spice-glib - mingw32-spice-gtk3 - mingw32-usbredir - mingw64-adwaita-icon-theme - mingw64-glib2 - mingw64-curl - mingw64-dbus - mingw64-dlfcn - mingw64-gcc - mingw64-gettext - mingw64-glib-networking - mingw64-glib2 - mingw64-gstreamer1-plugins-bad-free - mingw64-gstreamer1-plugins-good - mingw64-gtk3 - mingw64-gtk-vnc - mingw64-gtk3 - mingw64-hicolor-icon-theme - mingw64-libgovirt - mingw64-libssh2 - mingw64-libusbx - mingw64-libxml2 - mingw64-pkg-config - mingw64-portablexdr - mingw64-readline - mingw64-rest - mingw64-spice-glib - mingw64-spice-gtk3 - mingw64-usbredir The icotool command also becomes mandatory rather than optional when building with MinGW, but I have already posted a separate patch that takes care of the issue[1] so you should not concern yourself with that here. Provided you've taken care of all of the above, Reviewed-by: Andrea Bolognani <abologna(a)redhat.com&gt; [1] https://www.redhat.com/archives/libvir-list/2018-April/msg01164.html -- Andrea Bolognani / Red Hat / Virtualization