Re: [libvirt] [PATCH] lib: fix no zero arg check for iothread_id
On Mon, Aug 10, 2015 at 17:06:31 +0800, Luyao Huang wrote:
https://bugzilla.redhat.com/show_bug.cgi?id=1251886
We do not allow delete an iothread which id is 0 in
virDomainDelIOThread, but allow it in virDomainAddIOThread,
Also we will output an error when parse an iothread which id
is 0.
Add a check for iothread_id in virDomainAddIOThread to fix
it.
The limitation that iothread id shall not be 0 comes from the qemu
implementation so I think that we could possibly want to have iothread
id 0 in the future.
I think the check should be done in the qemu driver.
Peter
Attachments:
- signature.asc (application/pgp-signature — 819 bytes)