Re: [libvirt] [PATCH 1/1] virt-aa-helper: add unix channels (esp for qemu-guest-agent)
Quoting Serge Hallyn (serge.hallyn(a)ubuntu.com):
Quoting Ján Tomko (jtomko(a)redhat.com):
> On Mon, Apr 06, 2015 at 04:12:03PM +0000, Serge Hallyn wrote:
> > The original bug report was at
> > https://bugs.launchpad.net/ubuntu/+source/libvirt/+bug/1393842
> >
> > Signed-off-by: Serge Hallyn <serge.hallyn(a)ubuntu.com>
> > ---
> > src/security/virt-aa-helper.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
>
> ACK
>
> Should virt-aa-helper-test be updated too?
I guess so.
no - actually that test doesn't check for actual paths being present in
the result, and the test already checks that a unix channel doesn't make
virt-aa-helper crash. So adding a test for this would be greatly extending
the scope of the current testcase. Seems worth doing, but outside the scope
of this patch.
More importantly, are there cases in libvirt where there is a an
abstract
UNIX channel? If so then we'd have to avoid those cases. The current code
will write out an empty string for the file path, which probably will result
in a corrupt policy.
I'm sending an updated patch in reply to this email.