On Fri, Feb 22, 2019 at 11:09 AM Jiri Denemark <jdenemar@redhat.com> wrote:
On Fri, Feb 22, 2019 at 08:50:55 +0100, Peter Krempa wrote:
On Thu, Feb 21, 2019 at 21:44:34 +0300, David Kiarie wrote:
it looks sensible that the copyright notice on the affected files in updated as in this patch so as to also cover another party who hugely participated in writing the code.
I must point out that you specifically asked us to remove your name from the files:
https://www.redhat.com/archives/libvir-list/2018-May/msg00382.html
Which was fulfilled after the discussion in the thread above by:
https://www.redhat.com/archives/libvir-list/2018-May/msg00483.html
And now lives in the repo as:
commit d894e49292ae5135b6a9f44a634b5cfca4376f19 Author: David Kiarie <davidkiarie4@gmail.com> Date: Tue May 8 15:40:00 2018 +0300
xenconfig: remove my name and email from files
Did you change your mind?
yes, i will actually share the copyright, if possible.
Moreover, you removed 'Author: Kiarie Kahurani' lines while you want to add your name into a Copyright line now. Only SUSE was mentioned as the copyright holder when you created the files. This makes me think you might have contributed this as part of your contract with SUSE in which case you are most likely not the copyright holder (even though you didn't use a @suse.com email, but that's not rare some people just keep using their personal email).
i did this as part of GSoC. there was no contract. i think an email is personal enough that it shouldn't appear on copyright notice just like i can't have my phone number on the copyright declaration.
Jirka