Re: [libvirt] [PATCH v2 04/15] qemu: Handle postcopy-active migration state
On Fri, Jan 22, 2016 at 15:15:03 +0000, Daniel P. Berrange wrote:
On Thu, Jan 21, 2016 at 11:20:49AM +0100, Jiri Denemark wrote:
> Migration enters "postcopy-active" state after QEMU switches to
> post-copy and pauses guest CPUs. From libvirt's point of view this state
> is similar to "completed" because we need to transfer guest execution to
> the destination host.
It is the same 'completed' from te POV of internal migration API calls..
>From the end users POV though it is the same as migration active, since
we've not finished migration.
I can't tell from the code, but the virDomainJobInfo should still report
that migration is active, and not completed. Is it doing so ?
Yes, it's only the same from our internal POV. Querying job status will
still report the migration as active and the progress counters will be
updated until migration really completes.
The following change takes care of that:
- if (priv->job.current->type == VIR_DOMAIN_JOB_UNBOUNDED)
+ if (priv->job.current->type == VIR_DOMAIN_JOB_UNBOUNDED &&
!inPostCopy)
priv->job.current->type = VIR_DOMAIN_JOB_FAILED;
Jirka