Re: [PATCH v2] remote/stream-event: Fix a memory leak in?? remoteStreamCallbackFree()
On Thu, Jun 26, 2025 at 03:53:35 -0000, liu.song13(a)zte.com.cn
wrote:
Having two references this way would look confusing, so if you decide
that it is necessary please add a comment explaining why it is
necessary.
In this patch it looked extra confusing as you deleted an empty line
right after the second reference which looked like you wanted to just
move the reference.
I see, I didn't realize that the orginal reference is for
virStreamEventAddCallback, because it's after the call.
However the code here might be a little confusing and risky, the close events
may come early and unreference 'client' before we reference it. It might be
better to put the reference before virStreamEventAddCallback.