Re: [libvirt] [libvirt PATCH v6 13/15] xen_common: Change xenParsePCIList to using virConfGetValueStringList

On 09/18/2018 02:48 PM, Fabiano Fidêncio wrote: Since this call passes @false, that means virConfGetValueStringList processing will "fallthrough" the switch for VIR_CONF_STRING and thus generate an error and return -1. So to that degree OK, I agree this is no different than the previous code. I'll point out it's not a great design, but yes, no worse than before. Still if < 0, a virReportError was generated, thus we need to virResetLastError before returning 0 indicating we're going to ignore whether the "pci" value was found and whether it was the right type (e.g. since @false we only want VIR_CONF_LIST values. This will though cause us to miss memory allocation errors, but I have a feeling we'd hit another one real soon. So, this will be ugly and makes assumptions that may not be true in the called function forever, but would look something like this: int rc; if ((rc = virConfGetValueStringList(...)) <= 0) { if (rc < 0) { /* IOW: If called function didn't fail because the * cval->type switch fell through - since we're passing * @compatString == false - assumes failures for memory * allocation and VIR_CONF_LIST traversal failure * should cause -1 to be returned to the caller with * the error message set. */ if (virGetLastErrorCode() != VIR_ERR_INTERNAL_ERROR) return -1; /* If we did fall through the switch, then ignore and * clear the last error./ virResetLastError(); } return 0; } See, really ugly and not 100% supportable, but it should cover the existing cases. John