20 Jan
2014
20 Jan
'14
10:35 a.m.
On Fri, Jan 17, 2014 at 04:29:37PM -0800, Ian Main wrote:
On Thu, Jan 09, 2014 at 12:19:52PM +0100, Christophe Fergeau wrote:
Hey,
Wouldn't something like the patch below help to remove the code duplication in libvirt-sandbox-config-builder-{container,machine}.c ?
Christophe
Yes, definitely. My thinking was that the whole builder section should be gone over as there is still lots of duplicate code in there even with this patch.
I haven't looked very carefully for duplication, the code related to network interface was at least different enough not to look duplicated. Even if there is preexisting duplication, it's better to try to avoid adding more ;) Christophe