Re: [libvirt] [PATCH] host-validate: Improve CPU flags processing
On Wed, 2016-03-30 at 09:28 +0200, Andrea Bolognani wrote:
On Wed, 2016-03-30 at 08:36 +0200, Peter Krempa wrote:
>
> Since you are already using libvirt's utils ...
[...]
>
> Why not virStringSplit ...
[...]
>
> And STREQ?
No reason at all, really :)
On second thought, after having actually tried to implement
your suggestions...
virStringSplit() only supports a single delimiter, while
strtok_r() supports an arbitrary number - I'm using three in
my case.
So AFAICS the options are
- call virStringSplit() multiple times, hoping to take
all possible combinations into account
- enhance virStringSplit() to support multiple delimiters
- keep using strtok_r()
I'm quite partial to the last option :P
What about you?
Cheers.
--
Andrea Bolognani
Software Engineer - Virtualization Team